ACBS - Atoa Custom Battle System 3.2

[Atoa]

@ Lurker77
No, at last for me.
4shared is the only (free) host with an decent update file feature that allows me to update the download without changing the download link.

It would be really a pain each time i update the script, have to upload it in more than one host *and* update the links everywhere i posted it.

 

[zareth]

hey^^ I think I will post here instead of posting in RMVXP, seems to be a lot more activity in this thread^^ so first, the download worked only after 10 minutes waiting with Firefox and SkipScreen.

And second I found a few ?bugs?, so just ignore my post on RMVXP (btw i use almost all addons except a few like ctb):


1. Advanced Enemy Status line 329 syntax error
2. I got an error after a battle with the Chrono Trigger Battlesystem. Maybe it was because I lvled up but not sure... (line 1238, undefined method 'dead?')
3. If I want to open the status screen I got an error in ACBS | Battle Main Code line 567
4. When I am speaking with the Monsterbook guy an error occures in line 536 (name error)
5.solved^^
6.If I change the escape thing to escape with bar an error occures as soon as I press A in Battle: line 1473, type error

 

[Atoa]

@zareth
Your messages are quite vague.
Post an image with the message error and the exact situation that the error occured.

Also i need a list of all add-ons used when the error occurs. Because most bugs are incompatibilities.

 

[zareth]

OK sry for this^^

Screen 1:
http://img25.imageshack.us/i/56774330.png/
All Addons I use (for the first error Enemy Advanced Status implemented, for the others I had to took it out):

Screen 2:
http://img16.imageshack.us/i/95363042.png/
1. Error: Enemy Advanced Status Error when I start the game.

Screen 3:
http://img16.imageshack.us/i/95363042.png/
2. Error: Bestiary Error: When the Bestiary Scene is called.

Screen 4:
http://img689.imageshack.us/img689/2541/60687934.png
3. Error: Status Screen Error: If I want to access the status screen from the menu.

Screen 5:
http://img690.imageshack.us/i/53119760.png/
4. Error: Escape Bar Error: In Battle if I press A to escape this error occures.

I hope this is better :D

 

[Atoa]

Now we're talking the same language ;D

1. another mistake on translation \o
2. strange this error, it's an condition to check all party members, but it wasn't supposed to return nil. in any case i will add something to skip the chek if the actor = nil.
3. could you give more info about the conditions that the error occured? the line you show has nothing wrong.
4. another mistake on translation \o replace Exp_Name_Text with Exp_Text_Bestiary
5. .-.
6. this one was REALLY an bug ;D solved, i will upload the fix soon.

 

[zareth]

About the last error:

Chronotrigger Error: After the Victory Scene this error occures:
http://img132.imageshack.us/i/65312186.png/

New Error: When I use the Enemy Names Window an error occures when the last enemy has died:
http://img689.imageshack.us/i/20676347.png/

 

[Atoa]

@zareth
About the CT i know how to fix it(actually it's already fixed \o/), it's really easy, i just don't undestand why it's happening .-.

About the enemy name, that was a good catch. it's fixed also ;D

Thank for the help ;D

Only the error 3 i have no clue of what is happening, it don't happens on my test plays.

 

[zareth]

hm tried it again with the status but this error doesn't occure anymore Oo dunno why but great^^ is it normal that the battle command window is shown in the status screen? I don't think so, it's overlapping the rest^^

http://img97.imageshack.us/img97/2874/43079154.png


EDIT: I have a little Question: Does any Materia Script work with this battle system?
Not necessary anymore, Charlie Fleeds Skills Learning System seems to work with this^^

 

[Lurker77]

EDIT: I have a little Question: Does any Materia Script work with this battle system?
Not necessary anymore, Charlie Fleeds Skills Learning System seems to work with this^^

How did you get his skill learning system to work with this? Mine freezes after a battle ends (without any add-ons).

 

[Atoa]

is it normal that the battle command window is shown in the status screen?

It's an feature of Individual Battle Commands.

I can be turned off.

The materia currently doesn't work but i will make it work xD

 

[Huckleberry]

@Huckleberry
Another ridiculous mistake by atoa ;D
I forget to replace the old ATB with the new ATB.

I just reuploaded the demo, take a look on the ATB and see if it has a line named "def reset_bars". If so, that means that time I added the right code ;D

For now I can say i'm happy with the results, so far no real big bug was found, only some mistakes made by during the translations process XD

Yeeeeaaaaah! Wonderful job, Atoa, you can be proud of it !

I tried to do what you said, and (nearly) everything works.

I summon a summon. If my summon is killed, it is normally removed. The heroes are back and there is no bug anymore with ATB bar. So, the main part of the problem is solved.

Same if I use the skill "Summon Return".

But, I have ....... a bad new, and a new bug to show you !

Summon Script does not work correctly with the script "Individual Battle Command", which is almost essential for most gamers.

With Individual Battle Command, the summon can be killed : there will be no bug. Heroes will be back without any problem.

The problem is with the skill "Summon Return". If you want to return your summon while you are fighting, the bug is appearing immediately, here it is :

This bug only appears if you're using the script "Individual Battle Command." If you remove this script, there will not be any problem with the skill "Summon Return".

Conclusion : there is an incompatibility between the scripts "Summon" and "Individual Battle Command" for the skill "Summon Return". I've made many tries for this morning, and that is the only outcome I found. I'm sure this is just a detail in the scripts again.

Sorry, Atoa !

 

[zareth]

EDIT: I have a little Question: Does any Materia Script work with this battle system?
Not necessary anymore, Charlie Fleeds Skills Learning System seems to work with this^^

How did you get his skill learning system to work with this? Mine freezes after a battle ends (without any add-ons).

Yeah I made a change in 3 lines but the problem is that if the skill is learned there is no window after battle so you know that it has been learned^^

But if you want to try it out and if you have version 2.2 try this:
Go to the script Skills Learning System and in line 386 there is this:

Spoiler

if $charlie_lee_ctb != nil and $charlie_lee_ctb_version != nil and $charlie_lee_ctb_version >= 2.11
@result_window2.visible = false
end
@phase=5.1
@wait_count = 16
else
# Dispose learning window
@learning_window.dispose
battle_end(0)
end
end
end
end

change it to this

Spoiler

# if $charlie_lee_ctb != nil and $charlie_lee_ctb_version != nil and $charlie_lee_ctb_version >= 2.11
# @result_window2.visible = false
end
@phase=5.1
@wait_count = 16
else
# Dispose learning window
@learning_window.dispose
battle_end(0)
end
end
end
# end

 

[Atoa]

@Huckleberry
Can you post an image with the line that returned the error on the script editor?

In the default IBC the line 235 is different and could never return the error you posted, so I suppose you edited the script.

Also i had no issue with IBC + Summon and ATB + IBC + Summon.

So it may be some setting on the IBC.

 

[No ID]

Everything Seems to be working fine. Except for this one small problem on the Equipment Multi-Slots add-on.

Spoiler: Equipment Multi-Slots

This error happens no matter if I use the New Status add-on or not. All other equipment i.e. Helmet, Armor, Accessories, work just fine. Only the Shield or Left hand has this error.

 

[Huckleberry]

Yes, I forgot to put it.

Here is the message. Indeed, I edited the script.

If that's a mistake setting, you can see where it could be, just watching the error message ? Otherwise, I will try other tests.

 

[Atoa]

@No ID
Thanks for this one. fixed! ;D

@Huckleberry
Are you sure you updated the IBC?
On my code this line is:
"@skill_window.visible = false if @skill_window != nil"
what prevent this error.

In any case download the demo again and get the latest IBC code.

 

[Lurker77]

EDIT: I have a little Question: Does any Materia Script work with this battle system?
Not necessary anymore, Charlie Fleeds Skills Learning System seems to work with this^^

How did you get his skill learning system to work with this? Mine freezes after a battle ends (without any add-ons).

Yeah I made a change in 3 lines but the problem is that if the skill is learned there is no window after battle so you know that it has been learned^^

But if you want to try it out and if you have version 2.2 try this:
Go to the script Skills Learning System and in line 386 there is this:

Spoiler

if $charlie_lee_ctb != nil and $charlie_lee_ctb_version != nil and $charlie_lee_ctb_version >= 2.11
@result_window2.visible = false
end
@phase=5.1
@wait_count = 16
else
# Dispose learning window
@learning_window.dispose
battle_end(0)
end
end
end
end

change it to this

Spoiler

# if $charlie_lee_ctb != nil and $charlie_lee_ctb_version != nil and $charlie_lee_ctb_version >= 2.11
# @result_window2.visible = false
end
@phase=5.1
@wait_count = 16
else
# Dispose learning window
@learning_window.dispose
battle_end(0)
end
end
end
# end

I tried that. I end up getting another error:

Spoiler

An if I put a "#" before that line, it no longer freezes, but the battle reward screen immediately closes after the battle ends.

EDIT: If I use the FF7 victory window this isn't really a problem anymore because the window won't close until after you hit the action key and the EXP bars fill up.

 

[Huckleberry]

@Huckleberry
Are you sure you updated the IBC?
On my code this line is:
"@skill_window.visible = false if @skill_window != nil"
what prevent this error.

In any case download the demo again and get the latest IBC code.

How stupid am I... Indeed, I did not have updated the new Individual Battle Command script. I did not do it because I thought it was not necessary. It was negligence on my part (sorry).

I have just updated the IBC, and I made all settings ... And there is a new bug.

When the fight starts, when the ATB bar is loaded, this bug appears.

What a brainstorming ... I hope I did not forget to set anything in the settings, but I'm nearly sure I have done everything. If you look at the 206 line, you can see "set_name_windo_position" instead of "window". I tried to change it too, but the bug still appears.

I confess that I am a bit lost, but I won't stop to look for the solution.

 

[Atoa]

@Huckleberry
Again are you *sure* that you updated *ALL* scripts?

Disconsidering the typo (windo instad of window), the method "def set_name_windo_position" exist.
it's on line 3402 of the "ACBS | Battle Main Code", so if you updated the scripts, this error can't happen.

The typo dont interfere because i copy/paste the line so the error was in all lines xD

 

[Huckleberry]

That's it ! It took me a while, but I uploaded each script and set them all.

Everything is working now. I did not think it was necessary, fortunately that thou hast said. It seems logical really.

Next time I'll update each script.

Sorry to have made you waste your time with my stupid mistakes, and thank you again.