Weapon based accuracy

[european_son]

I'm trying to make the actor's hit rate dependent on both the actor's Int level and the equipped weapon. I haven't figured out a good algorithm yet, but I've made this block of code so far (in Game_Battler):

  #--------------------------------------------------------------------------

  # * Get Hit Rate

  #--------------------------------------------------------------------------

  def hit

    n = (int + 85) / 2

    case $data_weapons[@actor.weapon_id]

    when 1

      n = (int + 95) / 2

    when 2

      n = (int + 95) / 2

    when 3

      n = (int + 95) / 2

    when 11

      n = (int + 75) / 2

    end

    for i in @states

      n *= $data_states[i].hit_rate / 100.0

    end

    return Integer(n)

  end

 

The problem is that I get an 'undefined method' error pointing to 'weapon_id'. Any help would be greatly appreciated!

 

[Zeriab]

$data_weapons[@actor.weapon_id]
Change to
$data_weapons[@weapon_id]

 

[european_son]

Haha! Stupid me! Thanks, Zeriab!

EDIT: Oh, now the Hit Rate doesn't change. It's always the default value, no matter which weapon the actor has equipped. :huh:

 

[Ulqiorra]

where is 'int' defined?

And also, wouldn't it be '$data_weapons[@weapon_id].id' ?

 

[european_son]

wouldn't it be '$data_weapons[@weapon_id].id' ?

Yes, now it works. Thanks, Near!

where is 'int' defined?

It's defined in Game_Battler, a right above 'hit'.

 

[Ulqiorra]

Ahh... it's a method, okay! And you're welcome.

 

[european_son]

Ok, I think this topic is resolved now.

A suggestion: If someone has the talent, the time and the energy, a distributable & streamlined script for weapon based accuracy would be a cool addition to XP/VX. It was an integrated feature in 2000/2003 and I think the fact that it is not included in later versions is a big disapointment.

 

[Zeriab]

Note that $data_weapons[@weapon_id].id can give you an error if the actor has no weapon equipped.
In that case you have $data_weapons[@weapon_id] == nil
nil.id gives you an error

 

[Ulqiorra]

just do this:

[rgss] 
 
class NilClass
  def id
    return 1
  end
end
 
 
[/rgss]

You can use $data_weapons[@weapon_id] == nil,
but this works for armors, actors, and stuff without
the '== nil'.

 

[Zeriab]

I forgot that .id is a method in the Object class, so nil.id should not give an error, but instead a number. I dunno which.
My point with checking for nil still stands and I strongly advice against doing what Near's suggesting. Especially now that you know will overwrite an already existing function.
But even if that weren't the case adding properties to the NilClass like that is just horrible and it is something which can come back and bite you.

*hugs*

 

[european_son]

Having no weapon equipped has not caused any errors for me yet. Atleast in my menu system it shows this value when the actor is unarmed:

def hit

    [color=#FF0000]n = (int + 85) / 2[/color]

    case ...

I haven't been able to test the code in battle yet, though. I'm using GubiD's TBS, and I haven't been able to get it working properly. Anyways, after I make a topic of my game in the project discussion I may upload some kind f a demo and someone more advanced in RGSS might be able to take a look at my mess of scripts... :barf: