Ive got lag!!!

[trebor678]

Hey, I have this small script using StephSpawns slant bar, but i'm getting a tonne of lag! its going at 7/8 FPS!!! I'm using it in the Help Window when you go over an enemy, heres the code

  def set_enemy(enemy)
    text = enemy.name
    state_text = make_battler_state_text(enemy, 112, false)
    if state_text != ""
      text += "  " + state_text
    end
    text += " " + enemy.hp.to_s + "/" + enemy.maxhp.to_s
    draw_slant_bar(x + 120 ,y + 27, enemy.hp, enemy.maxhp, 80, 6)
    set_text(text, 1)
  end

Thanks :D

 

[trebor678]

Any way of stopping the lag?

 

[SephirothSpawn]

If it's redrawing it every frame, that's why.

Perhaps setting a flag for the last hp / maxhp value and only redrawing it when it updates wouldn't be a bad thing.

 

[trebor678]

That sounds good, but um.... how do i do that! Not the best scipter in the world :P

Thanks :D

 

[Daniel]

Something like:

if text != @text
  draw_slant_bar
end

 

[trebor678]

How would that go into the script? Sorry, not to good at this stuff!

Thanks :D

 

[Daniel]

Copy and paste it where it draws the slant bar, but replace where it says "draw_slant_bar" in the code I posted with your draw_slant_bar.

 

[trebor678]

I'm really sorry, but would you be able to make the script quickly for me, just combine what you've said and the script i posted,

Thank you very much :D:D:D

EDIT: Sorry, Ive just got what you wrote, Thanks :D

 

[trebor678]

OK, this is the code that I now have:

def set_enemy(enemy)
    text = enemy.name
    state_text = make_battler_state_text(enemy, 112, false)
    if state_text != ""
      text += " - " + state_text
    end
    text += " - " + enemy.hp.to_s + "/" + enemy.maxhp.to_s
    if text != @text
      draw_slant_bar(contents.width / 2 - 67, 25, enemy.hp, enemy.maxhp, 135, 6) # 80
    end
    draw_slant_bar(contents.width / 2 - 67, 25, enemy.hp, enemy.maxhp, 135, 6) # 80
    set_text(text, 1)
  end
end

But I'm still getting the lag!?

Thank You :D

 

[Daniel]

Delete the "draw_slant_bar" line that is above the "set_text(text, 1)" line.

 

[trebor678]

I did that, but now the bar doesnt even appear!?

 

[SephirothSpawn]

Because the set_text method clears the windows contents.

Use this:

  def set_enemy(enemy)
    text = enemy.name
    state_text = make_battler_state_text(enemy, 112, false)
    if state_text != ""
      text += " - " + state_text
    end
    text += " - " + enemy.hp.to_s + "/" + enemy.maxhp.to_s
    return if @text == text
    draw_slant_bar(contents.width / 2 - 67, 25, enemy.hp, enemy.maxhp, 135, 6) # 80
    set_text(text, 1)
  end

 

[trebor678]

Hi, thanks, but its still the same, the bar doesn't show still :S

 

[trebor678]

Does anyone else know what do to?

Thank You