Am I doing it right?

[seven]

So I just was trying to whip up a quick snippet for ccoa's UMS, so that when there is no face specified, game_system.ums_mode = FIT_WINDOW_TO_TEXT, and when there is a face, game_system.ums_mode = NORMAL_MODE.  Since I'm hopeless with scripting, I just need to know if I'm doing this correctly.  Would this update?  Would it cause lag?  Is there a more efficient way of writing it?  Where should I put the script?  I'm hopeless. :dead: Here's the code:

if $game_system.face_graphic = ""
  game_system.ums_mode = FIT_WINDOW_TO_TEXT
else game_system.ums_mode = NORMAL_MODE
end

Thanks! :smile:

 

[Dargor]

Well, I'm not sure what you're trying to do exactly, but, assuming that you want the text to use the proper space in the window depending on if there's a face graphic or not, then:

if $game_system.face_graphic == ""
  $game_system.ums_mode = FIT_WINDOW_TO_TEXT
else 
  $game_system.ums_mode = NORMAL_MODE
end

This should be added into the update method of Window_Message. I suggest to add it right below def update.
I've never used Ccoa's UMS but it should do the trick.

Take care!
-Dargor

 

[seven]

Well, I'm not sure what you're trying to do exactly, but, assuming that you want the text to use the proper space in the window depending on if there's a face graphic or not, then:

if $game_system.face_graphic = ""
  game_system.ums_mode = FIT_WINDOW_TO_TEXT
else 
  game_system.ums_mode = NORMAL_MODE
end

This should be added into the update method of Window_Message. I suggest to add it right below def update.
I've never used Ccoa's UMS but it should do the trick.

Take care!
-Dargor

Thanks!  I'll play around with it a bit to see if I can get the result I'm looking for. :smile:

 

[Sarkilas]

Don't forget $game_system. If you use it without $ you will just get an error if that block is ever run.

 

[Prexus]

$game_system.ums_mode = ($game_system.face_graphic == "" ? FIT_WINDOW_TO_TEXT : NORMAL_MODE)

you needed a double == on the first line of code (== is comparison, = is to set a variable, big difference.. = will always return true.)

but my line is just an easier way to do it.

 

[Sarkilas]

It's more clean, indeed, but personally, I don't like to have too much code exceeding the editing field's width, so I would've used the if blocks.

 

[Dargor]

I often forget about that ? : thing. Thanks for the reminder

 

[Prexus]

It's more clean, indeed, but personally, I don't like to have too much code exceeding the editing field's width, so I would've used the if blocks.

I find that interesting, actually. When I was taught to code at school, I was taught to use a few lines as possible, and condense. As long as the code still followed identical logical flow. Yet the year after I left school, they started teaching the "Don't exceed the window size, space your code out so its readable, etc." bullshit.

 

[Sarkilas]

I find that interesting, actually. When I was taught to code at school, I was taught to use a few lines as possible, and condense. As long as the code still followed identical logical flow. Yet the year after I left school, they started teaching the "Don't exceed the window size, space your code out so its readable, etc." bullshit.

Ahahaha! They were totally messing with your head :P

 

[Prexus]

I do fine with supercondensed code. As long as I leave breadcrumbs to find my way back to where things go (highly modular, lots of local methods, etc.)