Window Item Error

[kaze950]

I edited the Window_Item script so it would appear like this

#==============================================================================
# ** Window_Item
#------------------------------------------------------------------------------
#  This window displays items in possession on the item and battle screens.
#==============================================================================

class Window_Item2 < Window_Selectable
  #--------------------------------------------------------------------------
  # * Object Initialization
  #--------------------------------------------------------------------------
  def initialize
    super(0, 296, 200, 184)
    @column_max = 2
    refresh
    self.index = 0
    # If in battle, move window to center of screen
    # and make it semi-transparent
    if $game_temp.in_battle
      @column_max = 1
      self.y = 288
      self.height = 192
      self.width = 200
      self.opacity = 0
    end
  end
  #--------------------------------------------------------------------------
  # * Get Item
  #--------------------------------------------------------------------------
  def item
    return @data[self.index]
  end
  #--------------------------------------------------------------------------
  # * Refresh
  #--------------------------------------------------------------------------
  def refresh
    if self.contents != nil
      self.contents.dispose
      self.contents = nil
    end
    @data = []
    # Add item
    for i in 1...$data_items.size
      if $game_party.item_number(i) > 0
        @data.push($data_items[i])
      end
    end
    # Also add weapons and items if outside of battle
    unless $game_temp.in_battle
      for i in 1...$data_weapons.size
        if $game_party.weapon_number(i) > 0
          @data.push($data_weapons[i])
        end
      end
      for i in 1...$data_armors.size
        if $game_party.armor_number(i) > 0
          @data.push($data_armors[i])
        end
      end
    end
    # If item count is not 0, make a bit map and draw all items
    @item_max = @data.size
    if @item_max > 0
      self.contents = Bitmap.new(width - 32, row_max * 32)
      for i in 0...@item_max
        draw_item(i)
      end
    end
  end
  #--------------------------------------------------------------------------
  # * Draw Item
  #     index : item number
  #--------------------------------------------------------------------------
  def draw_item(index)
    item = @data[index]
    case item
    when RPG::Item
      number = $game_party.item_number(item.id)
    when RPG::Weapon
      number = $game_party.weapon_number(item.id)
    when RPG::Armor
      number = $game_party.armor_number(item.id)
    end
    if item.is_a?(RPG::Item) and
       $game_party.item_can_use?(item.id)
      self.contents.font.color = normal_color
          self.contents.font.size = 17
    else
      self.contents.font.color = disabled_color
          self.contents.font.size = 17
    end
    x = 4 + index % @column_max * (288 + 32)
    y = index / @column_max * 32
    rect = Rect.new(x, y, self.width / @column_max - 32, 32)
    self.contents.fill_rect(rect, Color.new(0, 0, 0, 0))
    bitmap = RPG::Cache.icon(item.icon_name)
    opacity = self.contents.font.color == normal_color ? 255 : 128
    self.contents.blt(x, y + 4, bitmap, Rect.new(0, 0, 24, 24), opacity)
    self.contents.draw_text(x + 28, y, 204, 32, item.name, 0)
    self.contents.draw_text(x + 28, y, 104, 32, ":", 2)
    self.contents.draw_text(x + 28, y, 128, 32, number.to_s, 2)
  end
  #--------------------------------------------------------------------------
  # * Help Text Update
  #--------------------------------------------------------------------------
  def update_help
    @help_window.set_text(self.item == nil ? "" : self.item.description)
  end
end

But, when it appears in battle, it looks strange.

http://img.photobucket.com/albums/v253/ ... WhYWhy.png[/IMG]

See, the items are supposed to be 'Potion, Full Potion, Elixer'. For some reason, the Elixer name and icon. If anyone can help with this, thank you.

 

[tibuda]

  def initialize
    super(0, 296, 200, 184)
    @column_max = 2
[COLOR=Red]    # refresh # delete this line[/COLOR]
    self.index = 0
    # If in battle, move window to center of screen
    # and make it semi-transparent
    if $game_temp.in_battle
      @column_max = 1
      self.y = 288
      self.height = 192
      self.width = 200
      self.opacity = 0
    end
[COLOR=Red]    refresh[/COLOR]
  end

that's because the window is refreshed before you change @column_max to 1. Look the things I changed...

 

[kaze950]

Thank you, I'm still a script newbie, but I'm trying to learn enough so I can do some basic functions. ^_^

 

[PhotonWeapon]

That screenshot looks neat, are battles taking place on maps or a regular Scene Battle screen?

 

[SephirothSpawn]

If you really wanted to, make Window_Item2 a sub-class of Window Item (class Window_Item2 < Window_Item). Any methods that are the same, you can remove from Window_Item2. So like methods like update_help, do not need to be in Window_Item2.

Just a way to reduce line count.