techinical difficultities altering Window_Skill

[Darth Cid]

In an admit to create a Final Fantasy fangame with a classic look I decided to alter the "Skills Window" to show 3 spells per columm, here's a default Window_Skill. (Note: I dunno how to do a hide/show window, it's not available on any other forum I've done.)

#==============================================================================
# ** Window_Skill
#------------------------------------------------------------------------------
#  This window displays usable skills on the skill and battle screens.
#==============================================================================

class Window_Skill < Window_Selectable
  #--------------------------------------------------------------------------
  # * Object Initialization
  #     actor : actor
  #--------------------------------------------------------------------------
  def initialize(actor)
    super(0, 128, 640, 352)
    @actor = actor
    @column_max = 2
    refresh
    self.index = 0
    # If in battle, move window to center of screen
    # and make it semi-transparent
    if $game_temp.in_battle
      self.y = 64
      self.height = 256
      self.back_opacity = 160
    end
  end
  #--------------------------------------------------------------------------
  # * Acquiring Skill
  #--------------------------------------------------------------------------
  def skill
    return @data[self.index]
  end
  #--------------------------------------------------------------------------
  # * Refresh
  #--------------------------------------------------------------------------
  def refresh
    if self.contents != nil
      self.contents.dispose
      self.contents = nil
    end
    @data = []
    for i in 0...@actor.skills.size
      skill = $data_skills[@actor.skills[i]]
      if skill != nil
        @data.push(skill)
      end
    end
    # If item count is not 0, make a bit map and draw all items
    @item_max = @data.size
    if @item_max > 0
      self.contents = Bitmap.new(width - 32, row_max * 32)
      for i in 0...@item_max
        draw_item(i)
      end
    end
  end
  #--------------------------------------------------------------------------
  # * Draw Item
  #     index : item number
  #--------------------------------------------------------------------------
  def draw_item(index)
    skill = @data[index]
    if @actor.skill_can_use?(skill.id)
      self.contents.font.color = normal_color
    else
      self.contents.font.color = disabled_color
    end
    x = 4 + index % 2 * (288 + 32)
    y = index / 2 * 32
    rect = Rect.new(x, y, self.width / @column_max - 32, 32)
    self.contents.fill_rect(rect, Color.new(0, 0, 0, 0))
    bitmap = RPG::Cache.icon(skill.icon_name)
    opacity = self.contents.font.color == normal_color ? 255 : 128
    self.contents.blt(x, y + 4, bitmap, Rect.new(0, 0, 24, 24), opacity)
    self.contents.draw_text(x + 28, y, 204, 32, skill.name, 0)
    self.contents.draw_text(x + 232, y, 48, 32, skill.sp_cost.to_s, 2)
  end
  #--------------------------------------------------------------------------
  # * Help Text Update
  #--------------------------------------------------------------------------
  def update_help
    @help_window.set_text(self.skill == nil ? "" : self.skill.description)
  end
end

Here's what's on my project.

#==============================================================================
# ** Window_Skill
#------------------------------------------------------------------------------
#  This window displays usable skills on the skill and battle screens.
#==============================================================================

class Window_Skill < Window_Selectable
  #--------------------------------------------------------------------------
  # * Object Initialization
  #     actor : actor
  #--------------------------------------------------------------------------
  def initialize(actor)
    super(0, 128, 640, 352)
    @actor = actor
    @column_max = [COLOR=Lime]3[/COLOR]
# [COLOR=lime]This part works because the selector will go down the line 3 spells a columm;[/COLOR] [COLOR=Red]however, the spell slots don't match the selector.[/COLOR]
    refresh
    self.index = 0
    # If in battle, move window to center of screen
    # and make it semi-transparent
    if $game_temp.in_battle
      self.y = 64
      self.height = 256
      self.back_opacity = 160
    end
  end
  #--------------------------------------------------------------------------
  # * Acquiring Skill
  #--------------------------------------------------------------------------
  def skill
    return @data[self.index]
  end
  #--------------------------------------------------------------------------
  # * Refresh
  #--------------------------------------------------------------------------
  def refresh
    if self.contents != nil
      self.contents.dispose
      self.contents = nil
    end
    @data = []
    for i in 0...@actor.skills.size
      skill = $data_skills[@actor.skills[i]]
      if skill != nil
        @data.push(skill)
      end
    end
    # If item count is not 0, make a bit map and draw all items
    @item_max = @data.size
    if @item_max > 0
      self.contents = Bitmap.new(width - 32, row_max * 32)
      for i in 0...@item_max
        draw_item(i)
      end
    end
  end
  #--------------------------------------------------------------------------
  # * Draw Item
  #     index : item number
  #--------------------------------------------------------------------------
  def draw_item(index)
    skill = @data[index]
    if @actor.skill_can_use?(skill.id)
      self.contents.font.color = normal_color
    else
      self.contents.font.color = disabled_color
    end
    x = [COLOR=Red]1 + index % 3 * (192 + 21)[/COLOR]
[COLOR=red]# I've been taking shots in the dark at this point to figure out how make all spells show themselves and their slots match the selector.[/COLOR]
    y = index / 2 * 32
    rect = Rect.new(x, y, self.width / @column_max - 32, 32)
    self.contents.fill_rect(rect, Color.new(0, 0, 0, 0))
    bitmap = RPG::Cache.icon(skill.icon_name)
    opacity = self.contents.font.color == normal_color ? 255 : 128
    self.contents.blt(x, y + 4, bitmap, Rect.new(0, 0, 24, 24), opacity)
    self.contents.draw_text(x + 28, y, 204, 32, skill.name, 0)
    self.contents.draw_text([COLOR=Lime]x + 80, y, 48[/COLOR], 32, skill.sp_cost.to_s, 2)
[COLOR=lime]# The new x measures successfully divided the MP(default SP) in the proper for the spells invisible.[/COLOR]
  end
  #--------------------------------------------------------------------------
  # * Help Text Update
  #--------------------------------------------------------------------------
  def update_help
    @help_window.set_text(self.skill == nil ? "" : self.skill.description)
  end
end

Can anyone help me?

 

[tibuda]

Yeah, I really thought this was annoying... That's why I changed the way things are drawed in my animated icons script, and you can do what just changing the @column_max.
What you are doing wrong is because you forgot to change the columns in the y coordinate. The better way is to not hard-code 2 or 3, but use @column_max.

    x = 1 + index % @column_max * (192 + 21)
# I've been taking shots in the dark at this point to figure out how make all spells show themselves and their slots match the selector.
    y = index / @column_max * 32

 

[Brewmeister]

Change the green numbers to make the column size add up.
Each column should be 181 with 32 between columns.

self.contents.draw_text(x + 28, y, 106, 32, skill.name, 0)
self.contents.draw_text(x + 130, y, 48, 32, skill.sp_cost.to_s, 2)

The Cursor (Selector) size is defined in Window_Selectable. And if you change it, it will effect all the windows with a
cursor (main menu, Item, Equip, etc...)

 

[Darth Cid]

Thank you both, you guys are geniuses, I'm adding your names to my Programming Troubleshooting credits now. A thousand thank yous.

 

[Raziel]

This topic has been resolved. If Darth Cid or any other users have any questions or further problems regarding this topic, please create a new thread about them.

Thank you!