[Resolved] my first script

[RelWes]

Hi, can you please tell me what's worng with this script?

 

class Swap_EP

  

 def initialize (msID)

  

     $game_temp.player_new_x = $game_map.events[msID].x

     $game_temp.player_new_y =  $game_map.events[msID].y

     

      $game_map.events[msID].x = $game_player.x

      $game_map.events[msID].y = $game_player.y

      

    

     

 end

 

end

It is supposed to swap between the player's location and some event's loaction.

 

[SephirothSpawn]

First off you don't need a class for this. You can actually just put the method in Game_Character.

class Game_Character

  def swap_position(event_id)

    character = event_id == 0 ? $game_player : $game_map.events[event_id]

    return if character == nil || character == self

    x, y = @x, @y

    moveto(character.x, character.y)

    character.moveto(x, y)

  end

end

Try that. To make something switch:

# Player with event

$game_player.swap_position(event_id)

 

# Event with event

$game_map.events[event_id].swap_position(event_id)

Just replace event_id in either case with the target event(s). Let me know how it works.


Errors with you code:
~ Event/Player (Game_Character objects) do not have access to the .x, .y variables.
~ You need to assign $game_temp..player_transferring must be set to true if you are planning on using the other $game_temp transfer flags.

 

[RelWes]

Edit:
Ah ok I understands this now.
Thank you!

EDIT2:

Question.. what this line do?:

return if character == nil || character == self

 

[BwdYeti]

If the character you're trying to swap with doesn't exist or is the same as the character initiating the swap it ends the method to prevent crashing/a useless swap.

 

[thefondrens]

This script is just what I needed, except is it possible to swap the player for an event on a different map?
I need to swap between players without losing position of either player, so I've been trying to make the player invisible, swap the player with a "hold" event, then transfer the player to the other map, then swap the player again with the other map's "hold" event, and then make the player reappear with the player 2 graphic.
Is there a script to swap player with event on another map to simplify this process?