menu edit error

Tar Nybuki · Feb 21, 2009

after 25 minutes i figured out how to remove the save option from the main menu.
i think it would look stupid for a game that uses a save crystal to have an unused save option on the menu.
here's my problem:

after i go to end game and then to cancel, it shows a blank button that doesn't do anything. how can i fix this?
btw to make the script i deleted s5 and made s4 the end game one.

Glitchfinder · Feb 21, 2009

Go to lines 50-71, which should look like this:

Code:

  #--------------------------------------------------------------------------

  # * Create Command Window

  #--------------------------------------------------------------------------

  def create_command_window

    s1 = Vocab::item

    s2 = Vocab::skill

    s3 = Vocab::equip

    s4 = Vocab::status

    s5 = Vocab::save

    s6 = Vocab::game_end

    @command_window = Window_Command.new(160, [s1, s2, s3, s4, s5, s6])

    @command_window.index = @menu_index

    if $game_party.members.size == 0          # If number of party members is 0

      @command_window.draw_item(0, false)     # Disable item

      @command_window.draw_item(1, false)     # Disable skill

      @command_window.draw_item(2, false)     # Disable equipment

      @command_window.draw_item(3, false)     # Disable status

    end

    if $game_system.save_disabled             # If save is forbidden

      @command_window.draw_item(4, false)     # Disable save

    end

  end

Now, change those lines to this:

Code:

  #--------------------------------------------------------------------------

  # * Create Command Window

  #--------------------------------------------------------------------------

  def create_command_window

    s1 = Vocab::item

    s2 = Vocab::skill

    s3 = Vocab::equip

    s4 = Vocab::status

    s5 = Vocab::game_end

    @command_window = Window_Command.new(160, [s1, s2, s3, s4, s5])

    @command_window.index = @menu_index

    if $game_party.members.size == 0          # If number of party members is 0

      @command_window.draw_item(0, false)     # Disable item

      @command_window.draw_item(1, false)     # Disable skill

      @command_window.draw_item(2, false)     # Disable equipment

      @command_window.draw_item(3, false)     # Disable status

    end

    if $game_system.save_disabled             # If save is forbidden

      @command_window.draw_item(4, false)     # Disable save

    end

  end

In case you were wondering what the problem was, check your copy where you see the s5 =... to the @command_window =...

Also, this isn't all you need to do. You also need to edit the following portion of code (found right after the section above)

Code:

  #--------------------------------------------------------------------------

  # * Update Command Selection

  #--------------------------------------------------------------------------

  def update_command_selection

    if Input.trigger?(Input::B)

      Sound.play_cancel

      $scene = Scene_Map.new

    elsif Input.trigger?(Input::C)

      if $game_party.members.size == 0 and @command_window.index < 4

        Sound.play_buzzer

        return

      elsif $game_system.save_disabled and @command_window.index == 4

        Sound.play_buzzer

        return

      end

      Sound.play_decision

      case @command_window.index

      when 0      # Item

        $scene = Scene_Item.new

      when 1,2,3  # Skill, equipment, status

        start_actor_selection

      when 4      # Save

        $scene = Scene_File.new(true, false, false)

      when 5      # End Game

        $scene = Scene_End.new

      end

    end

  end

so that it looks like this:

Code:

  #--------------------------------------------------------------------------

  # * Update Command Selection

  #--------------------------------------------------------------------------

  def update_command_selection

    if Input.trigger?(Input::B)

      Sound.play_cancel

      $scene = Scene_Map.new

    elsif Input.trigger?(Input::C)

      if $game_party.members.size == 0 and @command_window.index < 4

        Sound.play_buzzer

        return

      elsif $game_system.save_disabled and @command_window.index == 4

        Sound.play_buzzer

        return

      end

      Sound.play_decision

      case @command_window.index

      when 0      # Item

        $scene = Scene_Item.new

      when 1,2,3  # Skill, equipment, status

        start_actor_selection

      when 4      # End Game

        $scene = Scene_End.new

      end

    end

  end

Jason · Feb 22, 2009

But Glitch, I tried that (I was gonna help this dude), but the error still happens :crazy:

Tar Nybuki · Feb 22, 2009

def create_command_window
s1 = Vocab::item
s2 = Vocab::skill
s3 = Vocab::equip
s4 = Vocab::status
s5 = Vocab::save
@command_window = Window_Command.new(130, [s1, s2, s3, s4, s5])
@command_window.index = @menu_index
if $game_party.members.size == 0 # If number of party members is 0
@command_window.draw_item(0, false) # Disable item
@command_window.draw_item(1, false) # Disable skill
@command_window.draw_item(2, false) # Disable equipment
@command_window.draw_item(3, false) # Disable status
end
end

thats what i had before...i'll try it
line 58 nomethod error occured

Tar Nybuki · Feb 22, 2009

Heres all the scripts i edited.
Scene_Menu 50-94

Code:

 Â #--------------------------------------------------------------------------

Â  # * Create Command Window

Â  #--------------------------------------------------------------------------

Â  Â  def create_command_window

Â  Â  Â  s1 = Vocab::item

Â  Â  Â  s2 = Vocab::skill

Â  Â  Â  s3 = Vocab::equip

Â  Â  Â  s4 = Vocab::status

Â  Â  Â  s5 = Vocab::game_end

Â  Â  Â  @command_window = Window_Command.new(130, [s1, s2, s3, s4, s5])

Â  Â  Â  @command_window.index = @menu_index

Â  if $game_party.members.size == 0 # If number of party members is 0

Â  Â  @command_window.draw_item(0, false) # Disable item

Â  Â  @command_window.draw_item(1, false) # Disable skill

Â  Â  @command_window.draw_item(2, false) # Disable equipment

Â  Â  @command_window.draw_item(3, false) # Disable status

Â  Â  end

Â  end

Â 

Â  #--------------------------------------------------------------------------

Â  # * Update Command Selection

Â  #--------------------------------------------------------------------------

Â  def update_command_selection

Â  Â  if Input.trigger?(Input::B)

Â  Â  Â  Sound.play_cancel

Â  Â  Â  $scene = Scene_Map.new

Â  Â  elsif Input.trigger?(Input::C)

Â  Â  Â  if $game_party.members.size == 0 and @command_window.index < 4

Â  Â  Â  Â  Sound.play_buzzer

Â  Â  Â  Â  return

Â  Â  Â  elsif $game_system.save_disabled and @command_window.index == 4

Â  Â  Â  Â  Sound.play_buzzer

Â  Â  Â  Â  return

Â  Â  Â  end

Â  Â  Â  Sound.play_decision

Â  Â  Â  case @command_window.index

Â  Â  Â  when 0 Â  Â  Â # Item

Â  Â  Â  Â  $scene = Scene_Item.new

Â  Â  Â  when 1,2,3 Â # Skill, equipment, status

Â  Â  Â  Â  start_actor_selection

Â  Â  Â  when 4 Â  Â  Â # End Game

Â  Â  Â  Â  $scene = Scene_End.new

Â  Â  Â  end

Â  Â  end

Â  end

Vocab:

Code:

 Â # Status

Â  def self.status

Â  Â  return $data_system.terms.status

Â  end

Â 

Â  # Game End

Â  def self.save

Â  Â  return $data_system.terms.game_end

Â  end

I removed the save word.

Jason · Feb 22, 2009

Code:

 

   # Game End

   [b]def self.save     <---- ??? [/b]

     return $data_system.terms.game_end

   end

Glitchfinder · Feb 22, 2009

Tar Nybuki":118xy25c said:
thats what i had before...i'll try it
line 58 nomethod error occured

Not sure what could cause that error, it works fine for me. Also, to fix the final problem, find these lines in Scene_End (lines 38-43)

Code:

 Â #--------------------------------------------------------------------------

Â  # * Return to Original Screen

Â  #--------------------------------------------------------------------------

Â  def return_scene

Â  Â  $scene = Scene_Menu.new(5)

Â  end

and replace it with this:

Code:

 Â #--------------------------------------------------------------------------

Â  # * Return to Original Screen

Â  #--------------------------------------------------------------------------

Â  def return_scene

Â  Â  $scene = Scene_Menu.new(4)

Â  end

Jason · Feb 22, 2009

Glitchfinder":1oysxej8 said:
Tar Nybuki":1oysxej8 said:

thats what i had before...i'll try it
line 58 nomethod error occured

Click to expand...

Not dure what could cause that error, it works fine for me. Also, to fix the final problem, find these lines in Scene_End (lines 38-43)

Code:

Â #-------------------------------------------------------------------------- Â # * Return to Original Screen Â #-------------------------------------------------------------------------- Â def return_scene Â Â $scene = Scene_Menu.new(5) Â end

and replace it with this:

Code:

Â #-------------------------------------------------------------------------- Â # * Return to Original Screen Â #-------------------------------------------------------------------------- Â def return_scene Â Â $scene = Scene_Menu.new(4) Â end

Bingo !

Thats most likely what I missed off, lol. :cheers:

Glitchfinder · Feb 22, 2009

Oh, found the error. You removed a piece of necessary vocab. Just change the edited line (in the vocab module) back to:

Code:

  # Game End

  def self.game_end

    return $data_system.terms.game_end

  end

Tar Nybuki · Feb 22, 2009

Thank you so much! you've helped me complete my first custom script.

Glitchfinder · Feb 22, 2009

Tar Nybuki":3sm8uwl0 said:
Thank you so much! you've helped me complete my first custom script.

You're welcome. Just don't submit that to the current scripting contest.

Envision, Create, Share

menu edit error

Tar Nybuki

Glitchfinder

Jason

Tar Nybuki

Tar Nybuki

Jason

Glitchfinder

Jason

Glitchfinder

Tar Nybuki

Glitchfinder

Share this page

Thank you for viewing

Discord

RPG Maker

Content